Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): Youtube link not showing video on agent page #9068

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(store): Youtube link not showing video on agent page #9068

merged 1 commit into from
Dec 19, 2024

Conversation

Swiftyos
Copy link
Contributor

Fixes #9054

Changes

  • add the video link to the start of the images array

@Swiftyos Swiftyos requested review from a team as code owners December 19, 2024 10:00
@Swiftyos Swiftyos requested review from Pwuts and majdyz and removed request for a team December 19, 2024 10:00
@supabase Supabase
Copy link

supabase bot commented Dec 19, 2024

This pull request has been ignored for the connected project bgwpwdsxblryihinutbx because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@github-actions GitHub Actions
Copy link
Contributor

This PR targets the master branch but does not come from dev or a hotfix/* branch.

Automatically setting the base branch to dev.

@github-actions github-actions bot changed the base branch from master to dev December 19, 2024 10:00
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/s labels Dec 19, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 19, 2024

✅ Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 4874085
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6763eecc7ce5670008e8b8a5
😎 Deploy Preview https://deploy-preview-9068--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@qodo-merge-pro Qodo Merge Pro
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

9054 - Fully compliant

Compliant requirements:

  • Fix YouTube video links not showing on agent page
⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 PR contains tests
🔒 Security concerns

SQL injection:
The code sanitizes search queries by escaping special characters, but relies on string manipulation rather than parameterized queries. While basic escaping is implemented, a more robust solution using parameterized queries would be safer.

⚡ Recommended focus areas for review

Code Smell
The agent_video field is not included in the agent_image array when creating store agents response, which could lead to missing video content

@Swiftyos Swiftyos merged commit aaf4ee5 into dev Dec 19, 2024
18 of 20 checks passed
@Swiftyos Swiftyos deleted the swiftyos/open-2237-youtube-link-not-showing-video-on-agent-page branch December 19, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torantulino Torantulino Torantulino approved these changes

@Pwuts Pwuts Awaiting requested review from Pwuts Pwuts is a code owner automatically assigned from Significant-Gravitas/maintainers

@majdyz majdyz Awaiting requested review from majdyz majdyz is a code owner automatically assigned from Significant-Gravitas/maintainers

Assignees
No one assigned
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 4 size/s
Projects
Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Youtube link not showing video on agent page
2 participants
@Swiftyos @Torantulino